Add spatially-varying mean sea level #1000
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Hallberg-NOAA
requested changes
Dec 29, 2025
Member
Hallberg-NOAA
left a comment
Hallberg-NOAA
left a comment
There was a problem hiding this comment.
In my view, this PR will be ready to go once the instance of an inappropriate use of array syntax math (noted in a specific comment on the line in question) has been addressed.
Hallberg-NOAA
approved these changes
Jan 13, 2026
Member
Hallberg-NOAA
left a comment
Hallberg-NOAA
left a comment
There was a problem hiding this comment.
With the recent minor corrections, I think that these changes are all correct. Thank you for the addition of this valuable new capability.
The spatially varying time mean sea level meanSL is used as a reference height to calculate, e.g., time mean ocean column thickness max(meanSL + bathyT, 0.0). This field allows the model run in a domain with spatically varying mean height, e.g. the Great Lakes system. This first commit insulates the changes from the rest of the model. It only adds the field to ocean_grid_type and dyn_horgrid_type, the transcription between the two types, and a routine to read it from a file. The field is not yet used by the rest of the code.
This commit uses G%meanSL in 13 modules. The change is essentially replacing G%bathyT + G%Z_ref with G%meanSL + G%bathyT. Note that this does NOT mean parameter G%Z_ref is replaced by G%meanSL. G%Z_ref is factored in both G%meanSL and G%bathyT and it is kept as a useful consistency testing tool. Another cosmetic change is made by using G%meanSL + G%bathyT, instead of G%bathyT + G%meanSL, which (hopefully) can be easily interpreted as G%meanSL - (-G%bathyT).
max_depth is really used as a maximum static thickness throughout the model, so meanSL needs to be considered.
Hallberg-NOAA
force-pushed
the
add-meansl
branch
from
14ba725 to
8aa61c4
Compare
Member
|
This PR has passed pipeline testing at https://gitlab.gfdl.noaa.gov/ogrp/mom6ci/MOM6/-/pipelines/29846. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR adds a new 2D field
meanSLto grid control structure.meanSLis primarily used to handle a domain with spatially uneven long term mean surface level, with the Great Lakes being a prime example.bathyT,meanSLis referenced toz_refinocean_grid_type(and to zero indyn_horgrid_type).meanSLadopts height unit and is positive abovez_refor zero.meanSLis NOT replacingz_ref.z_refcan still be used as a uniform reference height for debugging/testing.z_refinto as a 2D field, topography will have to change to column thickness, which may not be very user-friendly._init, so this is probably not a lot of extra work. The exception isfind_face_areaunder certain configurations in barotropic solver.meanSLis uniformly zero (orz_refinternally), so there is no answer change.Edit: sorry for claiming the #1000 issue/pr/discussion.